Skip to content

Commit

Permalink
Remove unnecessary throws declarations in RoboMenuItemTest
Browse files Browse the repository at this point in the history
This commit removes unnecessary `throws Exception` declarations from test methods in `RoboMenuItemTest`.
  • Loading branch information
MGaetan89 authored and utzcoz committed Nov 22, 2024
1 parent 2a38781 commit cd13f1d
Showing 1 changed file with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,70 +26,70 @@ public void setUp() throws Exception {
}

@Test
public void shouldCheckTheMenuItem() throws Exception {
public void shouldCheckTheMenuItem() {
assertThat(item.isChecked()).isFalse();
item.setChecked(true);
assertThat(item.isChecked()).isTrue();
}

@Test
public void shouldAllowSettingCheckable() throws Exception {
public void shouldAllowSettingCheckable() {
assertThat(item.isCheckable()).isFalse();
item.setCheckable(true);
assertThat(item.isCheckable()).isTrue();
}

@Test
public void shouldAllowSettingVisible() throws Exception {
public void shouldAllowSettingVisible() {
assertThat(item.isVisible()).isTrue();
item.setVisible(false);
assertThat(item.isVisible()).isFalse();
}

@Test
public void expandActionView_shouldReturnFalseIfActionViewIsNull() throws Exception {
public void expandActionView_shouldReturnFalseIfActionViewIsNull() {
item.setActionView(null);
assertThat(item.expandActionView()).isFalse();
}

@Test
public void expandActionView_shouldSetExpandedTrue() throws Exception {
public void expandActionView_shouldSetExpandedTrue() {
item.setActionView(new View(ApplicationProvider.getApplicationContext()));
assertThat(item.expandActionView()).isTrue();
assertThat(item.isActionViewExpanded()).isTrue();
}

@Test
public void expandActionView_shouldInvokeListener() throws Exception {
public void expandActionView_shouldInvokeListener() {
item.setActionView(new View(ApplicationProvider.getApplicationContext()));
item.expandActionView();
assertThat(listener.expanded).isTrue();
}

@Test
public void collapseActionView_shouldReturnFalseIfActionViewIsNull() throws Exception {
public void collapseActionView_shouldReturnFalseIfActionViewIsNull() {
item.setActionView(null);
assertThat(item.collapseActionView()).isFalse();
}

@Test
public void collapseActionView_shouldSetExpandedFalse() throws Exception {
public void collapseActionView_shouldSetExpandedFalse() {
item.setActionView(new View(ApplicationProvider.getApplicationContext()));
item.expandActionView();
assertThat(item.collapseActionView()).isTrue();
assertThat(item.isActionViewExpanded()).isFalse();
}

@Test
public void collapseActionView_shouldInvokeListener() throws Exception {
public void collapseActionView_shouldInvokeListener() {
item.setActionView(new View(ApplicationProvider.getApplicationContext()));
listener.expanded = true;
item.collapseActionView();
assertThat(listener.expanded).isFalse();
}

@Test
public void methodsShouldReturnThis() throws Exception {
public void methodsShouldReturnThis() {
item = item.setEnabled(true);
assertThat(item).isNotNull();
item = item.setOnMenuItemClickListener(null);
Expand Down Expand Up @@ -131,7 +131,7 @@ public void methodsShouldReturnThis() throws Exception {
}

@Test
public void setIcon_shouldNullifyOnZero() throws Exception {
public void setIcon_shouldNullifyOnZero() {
assertThat(item.getIcon()).isNull();
item.setIcon(R.drawable.an_image);
assertThat(shadowOf(item.getIcon()).getCreatedFromResId()).isEqualTo(R.drawable.an_image);
Expand All @@ -140,7 +140,7 @@ public void setIcon_shouldNullifyOnZero() throws Exception {
}

@Test
public void getIcon_shouldReturnDrawableFromSetIconDrawable() throws Exception {
public void getIcon_shouldReturnDrawableFromSetIconDrawable() {
Drawable testDrawable =
ApplicationProvider.getApplicationContext().getResources().getDrawable(R.drawable.an_image);
assertThat(testDrawable).isNotNull();
Expand All @@ -150,14 +150,14 @@ public void getIcon_shouldReturnDrawableFromSetIconDrawable() throws Exception {
}

@Test
public void getIcon_shouldReturnDrawableFromSetIconResourceId() throws Exception {
public void getIcon_shouldReturnDrawableFromSetIconResourceId() {
assertThat(item.getIcon()).isNull();
item.setIcon(R.drawable.an_other_image);
assertThat(shadowOf(item.getIcon()).getCreatedFromResId()).isEqualTo(R.drawable.an_other_image);
}

@Test
public void setOnActionExpandListener_shouldReturnMenuItem() throws Exception {
public void setOnActionExpandListener_shouldReturnMenuItem() {
assertThat(item.setOnActionExpandListener(listener)).isSameInstanceAs(item);
}

Expand Down

0 comments on commit cd13f1d

Please sign in to comment.