Heat equation smoothing of IC

[wilfonba]

Description

This PR adds heat equation smoothing for ICs.

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

Scope

• This PR comprises a set of related changes with a common goal

How Has This Been Tested?

The following figures show a bunch of smoothing configurations, with black borders denoting processor boundaries:

The following examples were ran on Wingtip with 64 CPU ranks:

Checklist

• I have added comments for the new code
• I have made corresponding changes to the documentation (docs/)
• I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected
• I ran ./mfc.sh format before committing my code
• New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
• This PR does not introduce any repeated code (it follows the DRY principle)
• I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

• Checked that the code compiles using NVHPC compilers
• Checked that the code compiles using CRAY compilers
• Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
• Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
• Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature

The following shows strong and weak scaling on Frontier with and without RDMA mpi. Strong scaling was done with a 64m grid cell 3D_performance_test and starts at two ranks and ends at 32 ranks. Weak scaling was done with 8m grid cells per GPU using the same case file, beginning at two ranks and ending at 32 ranks.

[codecov]

Codecov Report

Attention: Patch coverage is 37.19298% with 179 lines in your changes missing coverage. Please review.

Project coverage is 43.67%. Comparing base (d863869) to head (e63a112).

Files with missing lines	Patch %	Lines
src/common/m_mpi_common.fpp	25.25%	138 Missing and 7 partials ⚠️
src/pre_process/m_perturbation.fpp	58.97%	13 Missing and 3 partials ⚠️
src/pre_process/m_mpi_proxy.fpp	0.00%	6 Missing ⚠️
src/common/m_helper_basic.f90	73.33%	0 Missing and 4 partials ⚠️
src/common/m_variables_conversion.fpp	0.00%	4 Missing ⚠️
src/post_process/m_global_parameters.fpp	0.00%	2 Missing ⚠️
src/pre_process/m_initial_condition.fpp	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   43.94%   43.67%   -0.27%     
==========================================
  Files          65       65              
  Lines       19039    19153     +114     
  Branches     2329     2338       +9     
==========================================
  Hits         8366     8366              
- Misses       9262     9361      +99     
- Partials     1411     1426      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sbryngelson]

+700 lines for just this one feature? is there anyway to trim this down?

[wilfonba]

@sbryngelson, I've addressed your comments. Now that I've modified code in simulation, I'll have to do more extensive testing tomorrow before this can be merged.