Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin parmed w/ numpy v2 #4883

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Unpin parmed w/ numpy v2 #4883

wants to merge 3 commits into from

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jan 7, 2025

Fixes #4625

Apparently parmed 4.3 now supports np 2+, let's test it out.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4883.org.readthedocs.build/en/4883/

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.65%. Comparing base (1eca9f2) to head (c2202f7).

Files with missing lines Patch % Lines
package/MDAnalysis/converters/ParmEd.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4883      +/-   ##
===========================================
- Coverage    93.66%   93.65%   -0.01%     
===========================================
  Files          177      189      +12     
  Lines        21796    22857    +1061     
  Branches      3067     3065       -2     
===========================================
+ Hits         20415    21407     +992     
- Misses         929      999      +70     
+ Partials       452      451       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin parmed imports once parmed supports numpy 2.0
1 participant