add explicit typings, add file-based package resolution #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this changes typings to local. it's worth noting, there is not exactly a benefit to this, as this is a template, and changes to the NPM package would not be reflected in people's clones of this template as a result. however, the NPM packages have not been updated in a while and are now outdated/inaccurate, and in the interest of keeping things carefree and adding less stress to your maintenance over a lightweight template, i think this would help people as if they wanted updated typings, they could simply fetch the latest from the template.
This commit adds an explicitly named type for the return of the `list()` function on an inventory peripheral. This allows for people to create their own typings based off of the slot detail or reference the type as part of their own code. This also contains one type fix, changing the `count` field on `ItemDetail` to a number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains two simple changes, one adds an explicit typing and one small fix to the type of the CraftOS declaration, and the other changes the package resolution to local files.
You can see my reasoning for both of these changes on the individual commits.