Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

January 2021 #364

Merged
merged 9 commits into from
Dec 28, 2020
Merged

January 2021 #364

merged 9 commits into from
Dec 28, 2020

Conversation

atomtay
Copy link
Contributor

@atomtay atomtay commented Dec 24, 2020

Pushing the January visualization here instead of directly going into dev/staging (in case more DataCommon work needs to go through to production before January 4).

Two "unusual" things about this month's release that are worth noting:

  • Since this uses react-leaflet and react-esri-leaflet, you'll need to run yarn install before running this branch
  • As I mention in Standardize gallery URLs #350, this visualization starts the process of standardizing our URLs to the /gallery subdirectory instead of the /calendar subdirectory (thus the url /gallery/2021/january). Since we got into a bit of a pattern with the calendar links, though, I've added a redirect in React away from /calendar/2021/january. It works on my end, but if you could double check it on your machine, that would be great.

@atomtay atomtay requested a review from mzagaja December 24, 2020 14:26
Copy link
Contributor

@mzagaja mzagaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this as is for now since it looks good and works, but am just curious if we can safely remove that leaflet script tag or not.

integrity="sha512-xodZBNTC5n17Xt2atTPuE1HxjVMSvLVW9ocqUKLsCC5CXdbqCmblAshOMAS6/keqq/sMZMZ19scR4PsZChSR7A=="
crossOrigin=""
/>
<script
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What needed this include? Testing in Chrome + Safari it looks ok without it.

@mzagaja mzagaja merged commit 53d2776 into dev Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants