Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize gallery URLs #350

Open
atomtay opened this issue Oct 15, 2020 · 1 comment
Open

Standardize gallery URLs #350

atomtay opened this issue Oct 15, 2020 · 1 comment

Comments

@atomtay
Copy link
Contributor

atomtay commented Oct 15, 2020

We currently have two URL "forms" for our data visualizations: first, users go to /gallery and pick a year (no change to the URL), and then click a month. Assuming that the month's visualization isn't a PDF, the user goes to /calendar/:year/:month. I think it could be worthwhile to standardize these URLs to the following:

  1. User goes to /gallery and lands on the current year.
  2. User selects another year (say, 2018); the URL changes to /gallery/2018. Going back to the most recent year (2020, as of writing) would change the URL to /gallery/2020. This way, we could link out directly to particular years just as we link out to particular months.
  3. User selects a month (August); the URL changes to /gallery/2020/august instead of /calendar/2020/august

We would need to set up routes for the years themselves in Rails as well as React Router, and it would probably be good practice to set up redirects for past gallery items so that old links aren't broken.

@atomtay
Copy link
Contributor Author

atomtay commented Dec 23, 2020

The forthcoming visualization will have the URL /gallery/2021/january, as will future visualizations. A re-direct should be set up in order to convert the 2020 urls from /calendar to /gallery

@atomtay atomtay mentioned this issue Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant