add cctv traj #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
odufour7
commented
Aug 22, 2024
odufour7
commented
- I modified the name of the cameras in the .json file to match the MADRAS article
- I added a new camera to the map the one at the exit of place des terreaux to match the MADRAS article
- I added a tab about visualisation in time and in space of trajectories on the place des terreaux. The data of cameras from airbnb just need to be updated to the right coordinate system (this can be added later in the python file also)
- I modified the contact_tab to make it more friendly and readable.
- I still have to included analysis of CCTV cameras
chraibi
requested changes
Aug 23, 2024
|
|
||
| fig, ax = plt.subplots(figsize=(2, 2), dpi=10) | ||
| sns.histplot(df['Total-number-of-collisions'], bins=bins, kde=True, log_scale=(log_plot[0], log_plot[1]), ax=ax) | ||
| def plot_histogram(df: pd.DataFrame, bins: int, log_plot: Tuple[bool, bool]) -> plt.Figure: |
|
Ok, I have made the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.