Improve GenerationParameters fields parsing #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot CLA Assistant bot All Contributors have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
Genteure
force-pushed
the
feat/gen-para-parsing
branch
2 times, most recently
from
4897b21 to
0cb2ea4
Compare
Genteure
force-pushed
the
feat/gen-para-parsing
branch
from
0cb2ea4 to
3c6e03f
Compare
ionite34
approved these changes
Jan 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current parser implementation fails to parse metadata generated by https://github.com/nkchocoai/ComfyUI-SaveImageWithMetaData with multiple LORAs.
This new parser is much more forgiving in terms of input text format.
Force push: I have removed
UnquoteValuesince it was added in the same commit that added regex parsing and it doesn't seems like anything else is depending on a unquoted value right now.