Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the file StabilityMatrix.Native.csproj so that the project can be debugged or run directly in the VisualStudio environment. #1045

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

alanpeng
Copy link
Contributor

@alanpeng alanpeng commented Dec 8, 2024

In the .csproj file, the expression of $([System.Runtime.InteropServices.RuntimeInformation]...) is not a directly supported MSBuild expression. MSBuild does not support calling runtime APIs directly in .

This results in the inability to directly debug or run the StabilityMatrix.Avalonia project after opening the project with VisualStudio.

Should be replaced by a RuntimeIdentifier based condition, for example:

true true true

In the .csproj file, the expression of $([System.Runtime.InteropServices.RuntimeInformation]...) is not a directly supported MSBuild expression. MSBuild does not support calling runtime APIs directly in <PropertyGroup>.

This results in the inability to directly debug or run the StabilityMatrix.Avalonia project after opening the project with VisualStudio.

Should be replaced by a RuntimeIdentifier based condition, for example:

<PropertyGroup Condition="'$(RuntimeIdentifier)' == 'win-x64'">
    <IsWindows>true</IsWindows>
</PropertyGroup>
<PropertyGroup Condition="'$(RuntimeIdentifier)' == 'osx-x64' Or '$(RuntimeIdentifier)' == 'osx-arm64'">
    <IsOSX>true</IsOSX>
</PropertyGroup>
<PropertyGroup Condition="'$(RuntimeIdentifier)' == 'linux-x64'">
    <IsLinux>true</IsLinux>
</PropertyGroup>
Copy link

github-actions bot commented Dec 8, 2024

CLA Assistant Lite bot CLA Assistant bot All Contributors have signed the CLA.

@alanpeng
Copy link
Contributor Author

alanpeng commented Dec 8, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@ionite34 ionite34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it seems using RuntimeIdentifier will be more consistent along with the main StabilityMatrix.Avalonia project that uses RuntimeIdentifier for resource bundling. Looks good, thank you!

@ionite34 ionite34 merged commit 21b78c2 into LykosAI:main Dec 9, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants