RavenDB-23556: Improve connection string validation and error handlin…

…g in `OngoingTasksHandler`
Lwiel · Jan 30, 2025 · 31e07ff · 31e07ff
1 parent 35749d1
commit 31e07ff
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/...ts/Handlers/Processors/OngoingTasks/OngoingTasksHandlerProcessorForGetConnectionString.cs b/...ts/Handlers/Processors/OngoingTasks/OngoingTasksHandlerProcessorForGetConnectionString.cs
@@ -29,8 +29,6 @@ public override async ValueTask ExecuteAsync()
 
             var connectionStringName = RequestHandler.GetStringQueryString("connectionStringName", false);
             var typeString = RequestHandler.GetStringQueryString("type", false);
-            if (Enum.TryParse(typeString, ignoreCase: true, out ConnectionStringType connectionStringType) == false && typeString != null)
-                throw new NotSupportedException($"Unknown connection string type: {connectionStringType}");
 
             await RequestHandler.ServerStore.EnsureNotPassiveAsync();
             RequestHandler.HttpContext.Response.StatusCode = (int)HttpStatusCode.OK;
@@ -42,9 +40,20 @@ public override async ValueTask ExecuteAsync()
                 using (context.OpenReadTransaction())
                 using (var rawRecord = RequestHandler.ServerStore.Cluster.ReadRawDatabaseRecord(context, RequestHandler.DatabaseName))
                 {
-                    connectionStrings = string.IsNullOrWhiteSpace(connectionStringName)
-                        ? rawRecord.GetConnectionString(connectionStringName, connectionStringType)
-                        : rawRecord.GetConnectionStrings();
+                    if (connectionStringName != null)
+                    {
+                        if (string.IsNullOrWhiteSpace(connectionStringName))
+                            throw new BadRequestException($"'{nameof(connectionStringName)}' must have a non empty value");
+
+                        if (Enum.TryParse(typeString, ignoreCase: true, out ConnectionStringType connectionStringType) == false)
+                            throw new BadRequestException($"Unknown connection string type: {typeString}");
+
+                        connectionStrings = rawRecord.GetConnectionString(connectionStringName, connectionStringType);
+                    }
+                    else
+                    {
+                        connectionStrings = rawRecord.GetConnectionStrings();
+                    }
                 }
 
                 await using (var writer = new AsyncBlittableJsonTextWriter(context, RequestHandler.ResponseBodyStream()))