Merge pull request #641 from Lumiwealth/float-in-historical-data-bug-fix

lumibot/data_sources/pandas_data.py

@@ -427,7 +427,14 @@ def get_start_datetime_and_ts_unit(self, length, timestep, start_dt=None, start_
         return start_datetime, ts_unit
 
     def get_historical_prices(
-        self, asset, length, timestep="", timeshift=None, quote=None, exchange=None, include_after_hours=True
+        self, 
+        asset: Asset,
+        length: int,
+        timestep: str = None,
+        timeshift: int = None,
+        quote: Asset = None,
+        exchange: str = None,
+        include_after_hours: bool = True,
     ):
         """Get bars for a given asset"""
         if isinstance(asset, str):

lumibot/entities/data.py

@@ -596,7 +596,7 @@ def get_bars(self, dt, length=1, timestep=MIN_TIMESTEP, timeshift=0):
 
         # The original df_result may include more rows when timestep is day and self.timestep is minute.
         # In this case, we only want to return the last n rows.
-        df_result = df_result.tail(n=num_periods)
+        df_result = df_result.tail(n=int(num_periods))
 
         return df_result
 

lumibot/strategies/strategy.py

@@ -3097,6 +3097,16 @@ def get_historical_prices(
         >>> self.log_message(f"Last price of BTC in USD: {last_ohlc['close']}, and the open price was {last_ohlc['open']}")
         """
 
+        # Get that length is type int and if not try to cast it
+        if not isinstance(length, int):
+            try:
+                length = int(length)
+            except Exception as e:
+                raise ValueError(
+                    f"Invalid length parameter in get_historical_prices() method. Length must be an int but instead got {length}, "
+                    f"which is a type {type(length)}."
+                )
+
         if quote is None:
             quote = self.quote_asset
 

setup.py

@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name="lumibot",
-    version="3.8.14",
+    version="3.8.15",
     author="Robert Grzesik",
     author_email="[email protected]",
     description="Backtesting and Trading Library, Made by Lumiwealth",