[crypto] allow platform to define its own CSPRNG #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @Damian-Nordic |
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 81.89% 87.53% +5.63%
==========================================
Files 415 486 +71
Lines 49557 60289 +10732
==========================================
+ Hits 40584 52773 +12189
+ Misses 8973 7516 -1457
|
Damian-Nordic
approved these changes
Jan 24, 2022
|
|
||
| OT_TOOL_WEAK otError otPlatCryptoRandomDeinit(void) | ||
| { | ||
| mbedtls_ctr_drbg_free(&sCtrDrbgContext); |
There was a problem hiding this comment.
What about sEntropyContext?
| #endif | ||
|
|
||
| #if !OPENTHREAD_RADIO | ||
| static mbedtls_ctr_drbg_context sCtrDrbgContext; |
There was a problem hiding this comment.
Wouldn't it be more future-proof if the context was passed via otCryptoContext like in other crypto functions? For example, what if a single application runs multiple OT instances?
There was a problem hiding this comment.
Or you did so, because Random::Crypto::MbedTlsContextGet() is global anyway?
There was a problem hiding this comment.
Yes, currently there are no multi-instances of RNGs algorithms in OT. Let me maybe push this change and explicitly ask OT community whether they envision a use-case for the future, and if so, i will add otCryptoContext param to otPlatCryptoRandom* functions.
- THCI changes for bbr reset procedure to make a better effort to reset and to also make sure to restart the otbr-agent prior to attempting a factoryreset to cover the case where the agent cannot currently communicate to the rcp. - THCI change to move from sudo service restart otbr-agent to sudo systemctl restart otbr-agent, which is more comprehensive. - THCI changes for multicast to use ipmaddr in both soc and bbr cases.
`bbr skipseqnuminc` should complete without error.
This commit contain smaller style changes in `Mac` and `SubMac`
This commit also adds `MacFilterAddressModeToString()`.
…read#7343) This will prevent unexpected multicast packets on the Thread network.
…thread#7350) This commit adds `AddressResolver::LookUp()` method which resolves an EID to an RLOC17 by checking if an existing entry already exists in the address cache table.
"BBR Sequence Number Updating" section in Thread Specification requires special wraps when increasing BBR Dataset Sequence Number.
This commit adds `Commissioner::Dataset` class which mirrors the public `otCommissioningDataset`. It also adds `ResignMode` enum which is used as input to `Stop()` method to indicate whether or not to resign from being the commissioner.
This commit enables BR to withdraw its local NAT64 prefix if a smaller one is found in network data. It might happen when two BRs join the Thread network at merely the same time and thus both advertise its local NAT64 prefix. The BR with numerically greater prefix will withdraw its NAT64 prefix.
Provide a setter for the message code to change it after initialization of the message. This complements the existing getter function `otCoapMessageGetCode`.
This commit removes the `otLogResult{Bbr/Platform}()` macros from
`logging.hpp` and instead have each module implement `LogError()`
method. The main goal behind this change to simplify the logging
module and reduce number of macros/definitions in it (to prepare for
new logging model to be introduced).
This commit avoid setting aError which is not read.
This commit provides the following changes: * Introduce a new otPlatCryptoRandom API * Move usage of mbedtls_entropy_* and mbedtls_ctr_drbg_* out of ARM PSA enabled platforms * Stop exposing internal mbedtls contextes for entropy and CTR DRBG in OpenThread API Signed-off-by: Lukasz Duda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the following changes:
mbedtls_entropy_*andmbedtls_ctr_drbg_*out of ARM PSA enabled platformsBackground: With TF-M enabled, access to secure random number generation should be done only via
psa_random_getfunction. Non-secure environment should not use crypto HW directly (which might be the case by using legacy mbedtls entropy and ctr_drbg functions.Signed-off-by: Lukasz Duda [email protected]