Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/event-seller] Event-Seller 매핑 #82

Merged
merged 7 commits into from
Sep 29, 2022
Merged

Conversation

IMHYEWON
Copy link
Member

@IMHYEWON IMHYEWON commented Sep 29, 2022

개요

Seller작업의 완료로 Seller_id를 사용하고 있는 기존 Event 서비스를 수정하였습니다.

작업한 내용

이벤트 도메인 관련 내용 수정

리뷰 가이드

Seller 도메인에 이벤트리스트 추가하였습니다 연관관계 및 메소드 적절한지 리뷰부탁해요
@daeunchung 님은 꼭 봐주세요

이슈번호

[#81]

@IMHYEWON IMHYEWON added the Fix 수정 label Sep 29, 2022
@IMHYEWON IMHYEWON added this to the 이벤트 milestone Sep 29, 2022
@IMHYEWON IMHYEWON self-assigned this Sep 29, 2022
Copy link
Contributor

@choihyeongjun choihyeongjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생 많으셧슴당

Copy link
Member

@jungeu1509 jungeu1509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 DTO에 AllargsConstructor 어노테이션 붙어있는데 직접만들어주는게 더 좋을거 같아요

Copy link
Contributor

@daeunchung daeunchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인완료 !

@IMHYEWON IMHYEWON merged commit 77b9019 into dev Sep 29, 2022
@IMHYEWON IMHYEWON deleted the feature/event-seller branch September 29, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix 수정
Projects
Development

Successfully merging this pull request may close these issues.

5 participants