Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing pos interval map entry in pose estimation #1208

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Fix missing pos interval map entry in pose estimation #1208

merged 4 commits into from
Jan 16, 2025

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Jan 7, 2025 •
edited
Loading

Description

Fixes #1207

  • allow population of missing entries in PositionIntervalMap during population of PoseEstimation
  • this added populate is done without transaction

Checklist:

  • N This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • NA This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 mentioned this pull request Jan 7, 2025
Closed
@samuelbray32 samuelbray32 marked this pull request as ready for review January 10, 2025 18:43
@samuelbray32 samuelbray32 requested a review from CBroz1 January 10, 2025 18:43
CBroz1
CBroz1 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only thing left is to run the position tests. Lmk if you want me to run them on my end

@samuelbray32
Copy link
Collaborator Author

@CBroz1 If you have a chance that would be great, otherwise I'll get it once I'm back!

CBroz1
CBroz1 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes all position pytests. We just need to resolve the changelog conflict before merging

@CBroz1 CBroz1 merged commit dbae127 into master Jan 16, 2025
17 checks passed
@CBroz1 CBroz1 deleted the 1207_fix branch January 16, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error when trying to populate PoseEstimation
2 participants
@samuelbray32 @CBroz1