Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moseq Pipeline #1056
base: master
Are you sure you want to change the base?
Moseq Pipeline #1056
Changes from 10 commits
9d6d3e1
28748f1
7d5d66c
09779a6
983f179
fdaff80
c2b4d4f
2e9ea46
62c8eef
36ad016
fe3c6d4
ccf370f
b8dfd42
310abf7
69335a8
fc46b37
c3c7b84
e5b2c1b
dc8435c
f92320b
d663e0e
3a1c079
589bdb2
7d30fc1
81f3dfa
3bfcb9f
8fd900b
5a33090
bd29c76
c7ea1f5
5901edc
e5af455
04c2a37
8106929
2bff705
31014f9
3dacc40
f61f10c
719486b
24e1150
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this looking for substrings? Is this results dict structured as
{'my_syllables': {'syllable': data_obj}
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indenting here makes it look like you're only working with the first key in results and ignoring the rest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a stab at a version that removes conditionals to make it easier to see how the data types are differential handled.