Allow configuring the i2c device at runtime #88
Conversation
|
Thank you for your inquiry. Customers are encouraged to submit technical questions via our dedicated support portal at https://semtech.force.com/ldp/ldp_support. We invite all users to visit the LoRa Developer Portal Forum at https://forum.lora-developers.semtech.com and to join the thriving LoRa development community! |
|
Duplicated from my #63 |
|
It's actually not - yours tries to do a lot more complicated of a thing that involves separating out where various sensors can be accessed, etc. Mine simply makes i2c configurable. It is a subset of the functionality of yours, for sure, but not sure that means anything. |
|
I agree with you. Hope you will have more chance to get this integrated in the repo. I guess unfortunately Semtech d'ont take public contribution... as indicated by the bot. |
|
Yes, it seems unfortunate. I did get one accepted over on the loramac project (SX12XX code), so maybe there is hope. If worst comes to worst, i will just start a version of this project that is a little more flexible/open. |
This patch adds the i2c device to the board configuration, so it can be configured at runtime, rather than just being a static macro.
It defaults to the value of the static macro for compatibility.