Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Modify Calendar Footer design and Unscheduled courses #503

Merged
merged 12 commits into from
Feb 13, 2025
Merged

feat(ui): Modify Calendar Footer design and Unscheduled courses #503

merged 12 commits into from
Feb 13, 2025

Conversation

EthanL06
Copy link
Member

@EthanL06 EthanL06 commented Jan 30, 2025 •
edited by Razboy20
Loading

#497

This change is Reviewable

@EthanL06 EthanL06 marked this pull request as draft January 30, 2025 05:05
@doprz doprz added wip UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap labels Jan 30, 2025
@EthanL06
Copy link
Member Author

Screenshot 2025-01-29 at 11 06 40 PM

I’m currently facing an issue with theme colors in UnoCSS. Specifically, the class name text-theme-offwhite1 (along with offwhite2, black1, and black2) is not being detected. This might be due to the numbers in the class names, which could be causing parsing issues

@EthanL06 EthanL06 marked this pull request as ready for review February 8, 2025 04:28
@doprz doprz linked an issue Feb 12, 2025 that may be closed by this pull request
Modify Calendar Footer design and Unscheduled courses #497
Closed
4 tasks
IsaDavRod
IsaDavRod approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@doprz doprz self-requested a review February 13, 2025 19:09
doprz
doprz approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz doprz merged commit b171f01 into Longhorn-Developers:main Feb 13, 2025
6 checks passed
@doprz doprz added this to the v2.1.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaDavRod IsaDavRod IsaDavRod approved these changes

@doprz doprz doprz approved these changes

Assignees

@EthanL06 EthanL06

Labels
feature ready-for-review UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Modify Calendar Footer design and Unscheduled courses
3 participants
@EthanL06 @IsaDavRod @doprz