feat(ui): course color picker #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stration-Plus into feature/color-picker
IsaDavRod
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Here are some things I've noticed:
- Async/Other courses should also have the color picker button
- The color picker button should be closer to the top right corner of the course block and, along with the color palette, should be slightly bigger. See the video below showing this PR vs the Figma component (Figma shows palette and color picker button as bigger):
https://github.com/user-attachments/assets/b2f13887-afdf-4c40-ae67-57c0542df7cb - Color picker button should have a shadow like other buttons.
- Ignore the Invert color button. That can be hidden for now. (I kind of want to make it a gear button that takes folks to the settings page to customize how colors work)
- There is a bug where courses glitch out of the grid when opening the color palette, and is fixed upon refresh. See video:
https://github.com/user-attachments/assets/e7ae7ea2-bc63-4812-9838-2f35869d3c1e
Razboy20
previously requested changes
Oct 28, 2024
There was a problem hiding this comment.
Reviewing on mobile so I'll have to come back and take a look at this later, but overall looking good.
I think it would be best if we used headless ui paradigms for rendering the floating elements rather than dealing with them manually, and that also enables easier animation/transitions.
Also, preferably (although I know it already exists in the codebase) remove types from JSDoc annotations, as you're repeating information given elsewhere-that is, through typescript.
I recommend trying to follow https://tsdoc.org/
src/views/components/calendar/CalendarCourseCellColorPicker/HexColorEditor.tsx
Outdated
Show resolved
Hide resolved
…pdate related props
… based on preview color
doprz
added
the
UI/UX-figma
IsaDavRod
requested changes
Jan 20, 2025
src/views/components/calendar/CalendarCourseCellColorPicker/HexColorEditor.tsx
Outdated
Show resolved
Hide resolved
doprz
requested changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #352
This change is