Added AddMetadataOfType extension (editor only)

LogicalError · Aug 30, 2024 · 5540896 · 5540896
1 parent 6015dbd
commit 5540896
Show file tree

Hide file tree

Showing 5 changed files with 55 additions and 17 deletions.
diff --git a/Editor/AssetExtensions.meta b/Editor/AssetExtensions.meta
diff --git a/Editor/AssetExtensions/AddMetadataOfTypeExtensions.cs b/Editor/AssetExtensions/AddMetadataOfTypeExtensions.cs
@@ -0,0 +1,12 @@
+using System.Runtime.CompilerServices;
+using UnityEngine;
+
+public static class AddMetadataOfTypeExtensions
+{
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    public static Metadata AddMetadataOfType<Metadata>(this Material asset)
+        where Metadata : CustomAssetMetadata
+    {
+        return AssetMetadataUtility.Add<Metadata>(asset) as Metadata;
+    }
+}
diff --git a/Editor/AssetExtensions/AddMetadataOfTypeExtensions.cs.meta b/Editor/AssetExtensions/AddMetadataOfTypeExtensions.cs.meta
diff --git a/Editor/Common/AssetMetadataUtility.cs b/Editor/Common/AssetMetadataUtility.cs
@@ -94,8 +94,7 @@ public static List<Type> AllMetadataTypes
 
 	public static string GetDisplayName(Type metadataType)
 	{
-		if (metadataType == null)
-			return null;
+		if (metadataType == null) throw new NullReferenceException(nameof(metadataType));
 		EnsureInitialized();
 		if (metadataNames.TryGetValue(metadataType, out var value))
 			return value.displayName;
@@ -104,17 +103,19 @@ public static string GetDisplayName(Type metadataType)
 
 	public static string GetMenuName(Type metadataType)
 	{
-        if (metadataType == null)
-            return null;
+		if (metadataType == null) throw new NullReferenceException(nameof(metadataType));
 		EnsureInitialized();
         if (metadataNames.TryGetValue(metadataType, out var value))
             return value.menuPath;
         return ObjectNames.NicifyVariableName(metadataType.Name);
 	}
 
 	public static void GetAll(UnityEngine.Object target, List<CustomAssetMetadata> metadata)
-    {
-        var assetPath = AssetDatabase.GetAssetPath(target);
+	{
+		if (target == null || ReferenceEquals(target, null)) throw new NullReferenceException(nameof(target));
+		if (metadata == null) throw new NullReferenceException(nameof(metadata));
+		EnsureInitialized();
+		var assetPath = AssetDatabase.GetAssetPath(target);
         if (assetPath == null ||
             string.IsNullOrEmpty(assetPath))
             return;
@@ -130,8 +131,11 @@ public static void GetAll(UnityEngine.Object target, List<CustomAssetMetadata> m
     }
 
     public static CustomAssetMetadata Add(UnityEngine.Object target, Type type)
-    {
-        if (!CanAddMetadataType(target, type))
+	{
+		if (target == null || ReferenceEquals(target, null)) throw new NullReferenceException(nameof(target));
+		if (type == null) throw new NullReferenceException(nameof(type));
+		EnsureInitialized();
+		if (!CanAddMetadataType(target, type))
             return null;
 
 		var assetPath = AssetDatabase.GetAssetPath(target);
@@ -161,9 +165,10 @@ public static CustomAssetMetadata Add(UnityEngine.Object target, Type type)
 	}
 
 	public static bool CanAddMetadataType(UnityEngine.Object target, Type type)
-    {
-        if (ReferenceEquals(target, null) || target == null)
-            return false;
+	{
+		if (type == null) throw new NullReferenceException(nameof(type));
+		if (target == null || ReferenceEquals(target, null)) throw new NullReferenceException(nameof(target));
+		EnsureInitialized();
         if (disallowMultipleMetadataLookup.Contains(type))
         {
             if (MetadataLookup.HasMetadataOfType(target, type))
@@ -184,15 +189,17 @@ public static bool CanAddMetadataType(UnityEngine.Object target, Type type)
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static CustomAssetMetadata Add<Metadata>(UnityEngine.Object target)
         where Metadata : CustomAssetMetadata
-    {
-        return Add(target, typeof(Metadata));
+	{
+		if (target == null || ReferenceEquals(target, null)) throw new NullReferenceException(nameof(target));
+		EnsureInitialized();
+		return Add(target, typeof(Metadata));
     }
 
     public static void Destroy<Metadata>(Metadata metadata)
         where Metadata : CustomAssetMetadata
-    {
-        if (metadata == null)
-            return;
+	{
+		if (metadata == null || ReferenceEquals(metadata, null)) throw new NullReferenceException(nameof(metadata));
+		EnsureInitialized();
 
         var assetPath = AssetDatabase.GetAssetPath(metadata);
         if (assetPath == null)

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
     "name": "com.custom_asset_metadata",
     "displayName": "Custom Asset Metadata",
-    "version": "1.1.0",
+    "version": "1.2.0",
     "unity": "2020.3",
     "description": "Adds the ability to store meta data on Assets",
     "license": "MIT",