更新至 v2.0.1 #245
Merged
更新至 v2.0.1 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
| @@ -467,13 +469,13 @@ def _read_user_list(path: Path) -> List[str]: | |||
| if not path: | |||
| return [] | |||
| if os.path.isfile(path): | |||
| with open(path, "r", encoding=_conf.preference.encoding) as f: | |||
| with open(path, "r", encoding=plugin_config.preference.encoding) as f: | |||
There was a problem hiding this comment.
UnicodeDecodeError can occur if the content of the file has characters incompatible with the OS's default encoding. Python uses the OS's default text encoding on the content because encoding is not set. Read more.
Closes: 242
[skip ci]
[skip ci]
# Conflicts: # README.md
# Conflicts: # src/nonebot_plugin_mystool/utils/good_image.py
Closed
# Conflicts: # README.md # pyproject.toml # src/nonebot_plugin_mystool/_version.py
(cherry picked from commit cd27a63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.