fix(tray): use PROJECT_NAME definition for tooltip

[ReenigneArcher]

Description

• Use common variable for tray tooltip assignment, using PROJECT_NAME definition.
• Two warnings are generated during build due to converting a string constant to char* fixed in Constify tooltip string pointer tray#8.

#18 57.17 /build/sunshine/src/system_tray.cpp: In function 'void system_tray::update_tray_stopped(std::string)':
#18 57.17 /build/sunshine/src/system_tray.cpp:343:20: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
#18 57.17   343 |     tray.tooltip = "Sunshine";
#18 57.17       |                    ^~~~~~~~~~
#18 57.17 /build/sunshine/src/system_tray.cpp: In function 'void system_tray::update_tray_require_pin()':
#18 57.17 /build/sunshine/src/system_tray.cpp:362:20: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
#18 57.17   362 |     tray.tooltip = "Sunshine";
#18 57.17       |                    ^~~~~~~~~~

Screenshot

Issues Fixed or Closed

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[cgutman]

I think we should fix this on the tray side by making that field a const char*. I'm going to upstream a PR to do that.

[cgutman]

dmikushin/tray#15

[ReenigneArcher]

Can you make a PR against our fork as well? https://github.com/LizardByte/tray

I'm not sure how far we've diverged from upstream, but would be nice to get it all in upstream.