fix: export PluginManager virtual function

LiteLDev · Jan 29, 2024 · 7ab056f · 7ab056f
1 parent d31cfcd
commit 7ab056f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/ll/api/plugin/PluginManager.h b/src/ll/api/plugin/PluginManager.h
@@ -37,14 +37,14 @@ class PluginManager {
 
     LLAPI bool erasePlugin(std::string_view name);
 
-    virtual ~PluginManager();
+    LLAPI virtual ~PluginManager();
 
     virtual bool load(Manifest manifest) = 0;
 
     virtual bool unload(std::string_view name) = 0;
 
-    virtual bool enable(std::string_view name);
+    LLAPI virtual bool enable(std::string_view name);
 
-    virtual bool disable(std::string_view name);
+    LLAPI virtual bool disable(std::string_view name);
 };
 } // namespace ll::plugin
diff --git a/src/ll/api/service/Service.cpp b/src/ll/api/service/Service.cpp
diff --git a/src/ll/api/service/Service.h b/src/ll/api/service/Service.h
@@ -6,7 +6,7 @@ namespace ll::service {
 
 class Service {
 public:
-    LLAPI virtual ~Service() = 0;
+    virtual ~Service() = default;
 
     [[nodiscard]] virtual ServiceId getServiceId() const noexcept = 0;
 
@@ -22,8 +22,6 @@ class Service {
     Service& operator=(Service&&)      = delete;
 };
 
-inline Service::~Service() = default;
-
 template <class T>
 concept IsService = std::is_base_of_v<Service, T> && requires {
     T::ServiceId;