[Skins] Adds an option to ignore skin inputFrames

- Fixes GBC skins created before mGBA was added
LitRitt · Mar 26, 2024 · b2a8671 · b2a8671
1 parent 3c6ccd6
commit b2a8671
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/Cores/DeltaCore b/Cores/DeltaCore
diff --git a/Ignited/Emulation/GameViewController.swift b/Ignited/Emulation/GameViewController.swift
@@ -1268,10 +1268,11 @@ private extension GameViewController
 
     func updateControllerSkinCustomization()
     {
-        self.controllerView.translucentControllerSkinOpacity = Settings.controllerFeatures.skin.opacity
+        guard let emulatorCore = self.emulatorCore else { return }
 
+        self.controllerView.translucentControllerSkinOpacity = Settings.controllerFeatures.skin.opacity
         self.controllerView.isDiagonalDpadInputsEnabled = Settings.controllerFeatures.skin.diagonalDpad
-
+        self.ignoreInputFrames = Settings.controllerFeatures.skin.ignoreInputFrames && emulatorCore.deltaCore.gameType != .ds
         self.backgroundColor = self.isEditingOverscanInsets ? UIColor.red : Settings.controllerFeatures.skin.colorMode.uiColor
     }
 

diff --git a/Ignited/Features/Controllers/SkinOptions.swift b/Ignited/Features/Controllers/SkinOptions.swift
@@ -60,6 +60,10 @@ struct SkinOptions
             description: "Enable to allow diagonal inputs on the corners of the D-Pad.")
     var diagonalDpad: Bool = true
 
+    @Option(name: "Ignore Input Frames",
+            description: "Enable to ignore the inputFrame provided by skins. Fixes improper cropping on legacy skins. Does not affect DS skins.")
+    var ignoreInputFrames: Bool = true
+
     @Option(name: "Restore Defaults",
             description: "Reset all options to their default values.",
             detailView: { _ in
+3 −2		DeltaCore/UI/Game/GameView.swift
+7 −1		DeltaCore/UI/Game/GameViewController.swift