Use C++20 as compile standard #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove non-functional compiler-flag test. Remove a contraction in an explanatory text so vim will highlight correctly. Always add -Wextra compiler flag. We are now completely warning free. Add configure option --enable-werror to force any warnings to become errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the required C++ standard to C++20, as discussed in #3296. The consequence is that Bullseye/Debian 11 is dropped as supported distribution and removed from CI.
Also fixed in this PR:
flagvs.commonflag). Regardless, the tested compiler-flag is unnecessary because the code has already been fixed (and the test always failed on clang). If compiler-flags are required you should add CFLAGS= or CXXFLAGS= to the configure command-line.-Wextra. We are currently completely warning free. Lets keep it that way.--enable-werrorto set the-Werrorcompiler-flag. In the near future this should be added to CI's rip-and-test and rip-and-test-clang tests to stay warning free.