Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#35 #36

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Fix/#35 #36

merged 3 commits into from
Jan 9, 2024

Conversation

sss4920
Copy link
Contributor

@sss4920 sss4920 commented Jan 9, 2024

🚩 κ΄€λ ¨ 이슈

πŸ“‹ κ΅¬ν˜„ κΈ°λŠ₯ λͺ…μ„Έ

  • νšŒμ› κ°€μž… μ‹œ NPE ν•΄κ²°

πŸ“Œ PR Point

  • 무슨 이유둜 μ–΄λ–»κ²Œ μ½”λ“œλ₯Ό λ³€κ²½ν–ˆλŠ”μ§€
    ν”„λ‘œν•„ 이미지 ν—ˆμš©μ„ μ•ˆν•˜λ©΄ responseμ—μ„œ null 값이 μ˜€λŠ” 것을 ν•΄κ²°ν–ˆμŠ΅λ‹ˆλ‹€.

  • μ–΄λ–€ 뢀뢄에 리뷰어가 집쀑해야 ν•˜λŠ”μ§€
    또 빠뜨린 뢀뢄이 μžˆλŠ”μ§€ ν™•μΈν•˜λ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.

  • κ°œλ°œν•˜λ©΄μ„œ μ–΄λ–€ 점이 κΆκΈˆν–ˆλŠ”μ§€
    sentry μ—„μ²­ νŽΈν•œ 것 κ°™μŠ΅λ‹ˆλ‹€.

πŸ“Έ κ²°κ³Όλ¬Ό μŠ€ν¬λ¦°μƒ·

{
    "code": 200,
    "message": "둜그인 성곡",
    "data": {
        "userId": 3,
        "accessToken": "μ €μ©Œκ΅¬",
        "refreshToken": "μ–΄μ©Œκ΅¬",
        "fcmToken": null,
        "isRegistered": true,
        "FcmIsAllowed": true,
        "profile": "기본이미지"
    }
}
image

πŸ› οΈ ν…ŒμŠ€νŠΈ

  • ν…ŒμŠ€νŠΈ

πŸš€ API Endpoint

  • baseurl/auth

@sss4920 sss4920 added the 🐞 fix Something isn't working label Jan 9, 2024
@sss4920 sss4920 requested a review from mmihye January 9, 2024 20:08
@sss4920 sss4920 self-assigned this Jan 9, 2024
@sss4920 sss4920 changed the base branch from develop to test January 9, 2024 20:08
@mmihye
Copy link
Member

mmihye commented Jan 9, 2024

척척박사

@sss4920 sss4920 merged commit 022aac9 into test Jan 9, 2024
1 check failed
@sss4920 sss4920 deleted the Fix/#35 branch January 9, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 fix Something isn't working
Projects
None yet
2 participants