[Feature] 카테고리 수정 API 두개로 분리 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Merge] 오타 변경 후 merge
[Merge] 각종 오류 해결
sss4920
approved these changes
Jan 16, 2024
| int currentPriority = category.getPriority(); | ||
| category.updateCategoryPriority(changeCateoryPriorityDto.newPriority()); | ||
|
|
||
| if(currentPriority < newPriority) |
There was a problem hiding this comment.
얘도 나중에 유지보수하기 좋게 주석으로 메모 넣어주면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 구현 기능 명세
📌 PR Point
무슨 이유로 어떻게 코드를 변경했는지
기존 로직중 우선순위를 정할때 유저별로 우선순위를 반영하는게 아니라 모든 카테고리에서 우선순위를 정했었는데
이러면 클라에서 변경 우선순위를 보내줬을때 이상하게 우선순위가 변경되어서 카테고리 생성시 우선순위를 현재유저의 우선순위 max +1 값으로 변경했습니다.
어떤 부분에 리뷰어가 집중해야 하는지
개발하면서 어떤 점이 궁금했는지
📸 결과물 스크린샷
🛠️ 테스트
🚀 API Endpoint