Merge pull request #48 from nacmartin/bugfix/wrong-optional-parameters

Fix optional parameters
Limenius · Oct 20, 2020 · be255b1 · be255b1
2 parents 4d0f947 + e5f85ec
commit be255b1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Limenius/ReactRenderer/Renderer/AbstractReactRenderer.php b/src/Limenius/ReactRenderer/Renderer/AbstractReactRenderer.php
@@ -30,7 +30,7 @@ abstract class AbstractReactRenderer
      *
      * @return array
      */
-    abstract public function render($componentName, $propsString, $uuid, $registeredStores = array(), $trace);
+    abstract public function render($componentName, $propsString, $uuid, $registeredStores = array(), $trace = false);
 
     /**
      * @return string
@@ -89,7 +89,7 @@ protected function initializeReduxStores($registeredStores = array(), $context =
      *
      * @return string
      */
-    protected function wrap($name, $propsString, $uuid, $registeredStores = array(), $trace)
+    protected function wrap($name, $propsString, $uuid, $registeredStores = array(), $trace = false)
     {
         $traceStr = $trace ? 'true' : 'false';
         $context = json_encode($this->contextProvider->getContext(true));

diff --git a/src/Limenius/ReactRenderer/Renderer/ExternalServerReactRenderer.php b/src/Limenius/ReactRenderer/Renderer/ExternalServerReactRenderer.php
@@ -28,7 +28,7 @@ class ExternalServerReactRenderer extends AbstractReactRenderer
      * @param ContextProviderInterface $contextProvider
      * @param LoggerInterface          $logger
      */
-    public function __construct($serverSocketPath, $failLoud = false, ContextProviderInterface $contextProvider, LoggerInterface $logger = null)
+    public function __construct($serverSocketPath, $failLoud, ContextProviderInterface $contextProvider, LoggerInterface $logger = null)
     {
         $this->serverSocketPath = $serverSocketPath;
         $this->failLoud = $failLoud;
@@ -53,7 +53,7 @@ public function setServerSocketPath($serverSocketPath)
      *
      * @return array
      */
-    public function render($componentName, $propsString, $uuid, $registeredStores = array(), $trace)
+    public function render($componentName, $propsString, $uuid, $registeredStores = array(), $trace = false)
     {
         if (strpos($this->serverSocketPath, '://') === false) {
             $this->serverSocketPath = 'unix://'.$this->serverSocketPath;

diff --git a/src/Limenius/ReactRenderer/Renderer/PhpExecJsReactRenderer.php b/src/Limenius/ReactRenderer/Renderer/PhpExecJsReactRenderer.php
@@ -50,7 +50,7 @@ class PhpExecJsReactRenderer extends AbstractReactRenderer
      * @param ContextProviderInterface $contextProvider
      * @param LoggerInterface          $logger
      */
-    public function __construct($serverBundlePath, $failLoud = false, ContextProviderInterface $contextProvider, LoggerInterface $logger = null)
+    public function __construct($serverBundlePath, $failLoud, ContextProviderInterface $contextProvider, LoggerInterface $logger = null)
     {
         $this->serverBundlePath = $serverBundlePath;
         $this->failLoud = $failLoud;
@@ -90,7 +90,7 @@ public function setServerBundlePath($serverBundlePath)
      *
      * @return array
      */
-    public function render($componentName, $propsString, $uuid, $registeredStores = array(), $trace)
+    public function render($componentName, $propsString, $uuid, $registeredStores = array(), $trace = false)
     {
         $this->ensurePhpExecJsIsBuilt();
         if ($this->needToSetContext) {