fix: bacalhau dind w/ nvidia #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgins
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Works on a CPU node modifying COMPUTE_MODE to cpu and sending a cowsay job.
Noticed that cancelling out of docker compose -f ./docker/docker-compose.yml up left Bacalhau in a bad state where it would not restart:
bacalhau | time="2024-12-06T19:39:38.542704888Z" level=info msg="Starting up"
bacalhau | failed to start daemon, ensure docker is not running or delete /var/run/docker.pid: process with PID 7 is still runningStopping with docker compose -f ./docker/docker-compose.yml down did not have this issue. May be worth investigating if this would surface during restarts.
narbs91
reviewed
Dec 6, 2024
narbs91
approved these changes
Dec 6, 2024
I added a |
walkah
added a commit
that referenced
this pull request
Dec 10, 2024
* fix: bacalhau dind w/ nvidia * fix: smaller RP image * fix: PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our current
bacalhaucontainer was not properly mounting nvidia drivers (nor subsequently making them available to job containers). This PR makes a few changes:dind) and nvidia container toolkit/var/run/docker.sockas a volume)Task/Issue reference
Closes: #440
Test plan
On a GPU-enabled machine, build the current container version via:
docker compose -f ./docker/docker-compose.yml builddocker compose -f ./docker/docker-compose.yml up