Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sign cla + fix typos #446

Closed
wants to merge 5 commits into from
Closed

chore: sign cla + fix typos #446

wants to merge 5 commits into from

Conversation

omahs
Copy link

@omahs omahs commented Nov 20, 2024

chore: sign cla + fix typos

@omahs omahs requested a review from a team as a code owner November 20, 2024 10:24
Copy link

cla-bot bot commented Nov 20, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @omahs on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again.

@github-actions github-actions bot added the chore label Nov 20, 2024
@bgins
Copy link
Contributor

bgins commented Nov 20, 2024

Hey @omahs! Thanks for all the typo fixes, much appreciated! ❤️

One last step for signing the CLA. Could you add an entry with your name and GitHub username to the NOTICES.md? (https://github.com/Lilypad-Tech/lilypad/blob/main/NOTICES.md)

Copy link

cla-bot bot commented Nov 20, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @omahs on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again.

@omahs
Copy link
Author

omahs commented Nov 20, 2024

@bgins Thanks for the quick review! Just added the change to NOTICES.md

@bgins
Copy link
Contributor

bgins commented Nov 20, 2024

@bgins Thanks for the quick review! Just added the change to NOTICES.md

Thanks @omahs! The field for "Licensee’s name" should be your real name because this is a legal document.

If you feel uncomfortable providing your real name in public, we could consider an alternative like signing a PDF version of the CLA. If that's the case, ping me in the #open-source channel in Discord (my Discord handle is also @bgins) and we can start a DM to work it out.

@omahs
Copy link
Author

omahs commented Nov 20, 2024

@bgins I'm completely fine with someone from your team redoing the commits instead, as I’d prefer to remain pseudonymous. I hope that's okay with you.

@bgins
Copy link
Contributor

bgins commented Nov 20, 2024

@bgins I'm completely fine with someone from your team redoing the commits instead, as I’d prefer to remain pseudonymous. I hope that's okay with you.

Yes, that's totally alright! Completely understand your desire to remain pseudonymous.

I will put in a PR with the typo fixes, and thank you for bringing the issues to our attention.

@bgins bgins mentioned this pull request Nov 20, 2024
1 task
@bgins
Copy link
Contributor

bgins commented Nov 20, 2024

Closed in favor of #448

@bgins bgins closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants