-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sign cla + fix typos #446
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @omahs on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again. |
Hey @omahs! Thanks for all the typo fixes, much appreciated! ❤️ One last step for signing the CLA. Could you add an entry with your name and GitHub username to the |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @omahs on file. In order for us to review and merge your code, please open a new pull request and sign the Contributor License Agreement following the instructions in our contributing guide. Once the pull request is merged, ping a maintainer who will summon me again. |
@bgins Thanks for the quick review! Just added the change to |
Thanks @omahs! The field for "Licensee’s name" should be your real name because this is a legal document. If you feel uncomfortable providing your real name in public, we could consider an alternative like signing a PDF version of the CLA. If that's the case, ping me in the |
@bgins I'm completely fine with someone from your team redoing the commits instead, as I’d prefer to remain pseudonymous. I hope that's okay with you. |
Yes, that's totally alright! Completely understand your desire to remain pseudonymous. I will put in a PR with the typo fixes, and thank you for bringing the issues to our attention. |
Closed in favor of #448 |
chore: sign cla + fix typos