feat: Upgrade to bacalhau 1.6 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkah
requested changes
Dec 5, 2024
walkah
force-pushed
the
bacalhau-upgrade
branch
2 times, most recently
from
d460bbf to
0406e23
Compare
walkah
force-pushed
the
bacalhau-upgrade
branch
from
ee15bfb to
5d88d99
Compare
walkah
approved these changes
Jan 9, 2025
walkah
reviewed
Jan 9, 2025
Comment on lines
+53
to
+67
| - name: Start solver | ||
| run: | | ||
| ./stack solver --disable-telemetry=true --api-host="" > solver.log & | ||
| sleep 5 | ||
|
|
||
| - name: Display resource provider logs | ||
| run: docker logs resource-provider | ||
| - name: Run solver integration tests | ||
| run: ./stack integration-tests-solver | ||
|
|
||
| - name: Start resource provider | ||
| run: | | ||
| ./stack resource-provider --disable-telemetry=true --api-host="" > resource-provider.log & | ||
| sleep 5 | ||
|
|
||
| - name: Run main integration tests | ||
| run: ./stack integration-tests |
There was a problem hiding this comment.
This staged set of integration tests allows us to run solver tests without having resource offers being added by an RP. This will be important for #462 e.g.
walkah
reviewed
Jan 9, 2025
Comment on lines
-36
to
-42
| # Install Bacalhau | ||
| RUN cd /tmp && \ | ||
| wget https://github.com/bacalhau-project/bacalhau/releases/download/v1.3.2/bacalhau_v1.3.2_linux_amd64.tar.gz && \ | ||
| tar xfv bacalhau_v1.3.2_linux_amd64.tar.gz && \ | ||
| mv bacalhau /usr/local/bin/bacalhau && \ | ||
| rm bacalhau_v1.3.2_linux_amd64.tar.gz | ||
|
|
There was a problem hiding this comment.
Using the http API means we no longer need to also have the bacalhau CLI installed here
bgins
reviewed
Jan 10, 2025
| @@ -17,8 +17,8 @@ RUN mkdir -pm755 /etc/apt/keyrings && curl -o /etc/apt/keyrings/docker.asc -fsSL | |||
| RUN nvidia-ctk runtime configure --runtime=docker --set-as-default | |||
|
|
|||
| # Install Bacalhau | |||
| ADD https://github.com/bacalhau-project/bacalhau/releases/download/v1.3.2/bacalhau_v1.3.2_linux_amd64.tar.gz . | |||
| RUN tar xfv bacalhau_v1.3.2_linux_amd64.tar.gz | |||
| ADD https://github.com/bacalhau-project/bacalhau/releases/download/v1.6.0/bacalhau_v1.6.0_linux_amd64.tar.gz . | |||
bgins
reviewed
Jan 10, 2025
bgins
reviewed
Jan 10, 2025
bgins
reviewed
Jan 10, 2025
bgins
reviewed
Jan 10, 2025
bgins
reviewed
Jan 10, 2025
| @@ -1,4 +1,4 @@ | |||
| //go:build integration | |||
| //go:build integration && solver | |||
bgins
reviewed
Jan 10, 2025
| @@ -51,6 +51,7 @@ func SetupLogging() { | |||
| logLevel = parsedLogLevel | |||
| } | |||
| zerolog.CallerSkipFrameCount = 3 // Skip 3 frames (this function, log.Output, log.Logger) | |||
| zerolog.SetGlobalLevel(logLevel) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the following changes:
Important Changes and Notes for clean up
Task/Issue reference
Test plan
./stack integration-tests)You can also verify the output recieved using the following:
ipfs add -nQr /tmp/lilypad/data/downloaded-files/<DEALID>(using the output path from the CLI). The resulting CID should match theDataIDprovided by the CLI. See: