feat: Add Lilypad version HTTP header #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgins
force-pushed
the
bgins/feat-add-version-header
branch
from
866ec01 to
2f63ace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the following changes:
X-Lilypad-VersionHTTP headerThe
X-Lilypad-Versionheader is added to all HTTP requests across services.As a demonstration, this PR adds a solver log to report the version when a resource provider makes an add resource offer post. We can remove the log or keep it if it seems useful.
Task/Issue reference
Closes: #406
Test plan
Build the binary with a placeholder version for testing:
Run the stack, using the binary for the resource provider and supplying our development-only private key:
Check the solver logs for a "resource provider adding offer with version header v2.9.0" log.