fix slow calculations of classification metrics #2876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2868
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun? Yes
Make sure you had fun coding 🙃
Details
The flag for the _TORCH_GREATER_EQUAL_1_12 was removed on the changed line in the following commit: 346bcdc
Now problem with the removal is that if before condition for checking was:
if torch.are_deterministic_algorithms_enabled() or _XLA_AVAILABLE or _TORCH_GREATER_EQUAL_1_12 and x.is_mps:
which meant if tensor was on mps and torch was greater or equal 1.12 it would choose the conditional path. With removal of the flag _TORCH_GREATER_EQUAL_1_12, now for the code to enter this path the XLA should be available and tensor should be on mps and I don't think there is such a device at all that supports both XLA and mps tensors. After changing the code the performance issue on the issue posted above gets fixed
📚 Documentation preview 📚: https://torchmetrics--2876.org.readthedocs.build/en/2876/