Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update caching to resolve concurrency #2869

Merged
merged 25 commits into from
Jan 6, 2025
Merged

ci: update caching to resolve concurrency #2869

merged 25 commits into from
Jan 6, 2025

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 16, 2024

What does this PR do?

we have some false negative CI failing on master when multiple jobs try to update caches simultaneously. It also blocks the jobs for a much longer time than required...
image

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2869.org.readthedocs.build/en/2869/

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41%. Comparing base (d9697b6) to head (14ac882).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2869     +/-   ##
========================================
- Coverage      69%     41%    -28%     
========================================
  Files         346     346             
  Lines       19142   19142             
========================================
- Hits        13230    7891   -5339     
- Misses       5912   11251   +5339     

@Borda Borda closed this Dec 17, 2024
@Borda Borda reopened this Dec 17, 2024
.github/workflows/ci-tests.yml Outdated Show resolved Hide resolved
@Borda Borda changed the title ci: update caching to resolve concurrency [WIP] ci: update caching to resolve concurrency Jan 6, 2025
@Borda Borda merged commit f7235c9 into master Jan 6, 2025
64 checks passed
@Borda Borda deleted the ci/caching branch January 6, 2025 16:02
@Borda Borda added the bug / fix Something isn't working label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant