Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear list states (i.e. delete their contents), not reassign the default [] #2493

Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
11df0eb
Clear (i.e. delete) list state items, not simply overwrite. Previous …
Apr 6, 2024
1fa7077
Added test to check list states elements are deleted (even when refer…
Apr 7, 2024
4b5c099
Updated documentation - highlighted reset clears list states, and tha…
Apr 9, 2024
8bf151b
Add missing method (sphinx) role
dominicgkerr Apr 9, 2024
64fd4d2
Merge branch 'master' into bugfix/2492-clear-list-states-not-reassign
Borda Apr 10, 2024
b991b3b
Merge branch 'master' into bugfix/2492-clear-list-states-not-reassign
mergify[bot] Apr 11, 2024
82f808b
changelog
SkafteNicki Apr 12, 2024
65b02fa
Remove failing testcode example (fixing introduces too much complexity)
Apr 12, 2024
b9dcc8b
Merge branch 'master' into bugfix/2492-clear-list-states-not-reassign
mergify[bot] Apr 13, 2024
5565524
Merge branch 'bugfix/2492-clear-list-states-not-reassign' of github.c…
Apr 13, 2024
6241a6b
Linting - Line break docstring
Apr 13, 2024
5758977
copy internal states in forward
SkafteNicki Apr 13, 2024
c9d2a86
Detach Tensor | list[Tensor] state values before copying.
Apr 13, 2024
e1872de
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 13, 2024
afdd4c5
Use 'typing' type hints
Apr 13, 2024
76cc0a1
Merge remote-tracking branch 'origin/bugfix/2492-clear-list-states-no…
Apr 13, 2024
ef27215
DO not clone (when caching) Tensor states, but retain references to a…
Apr 13, 2024
e104587
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 13, 2024
21c7970
Revert "DO not clone (when caching) Tensor states, but retain referen…
Apr 13, 2024
51975a8
Added mypy type-hinting requirement/recommendation
Apr 13, 2024
5954d02
Moved update from test checking .__init__ memory leakage. Added test …
Apr 13, 2024
cd11bb0
Merge branch 'master' into bugfix/2492-clear-list-states-not-reassign
mergify[bot] Apr 14, 2024
dc14e5e
Merge branch 'master' into bugfix/2492-clear-list-states-not-reassign
SkafteNicki Apr 15, 2024
925a3b1
Merge branch 'master' into bugfix/2492-clear-list-states-not-reassign
Borda Apr 15, 2024
3f013cf
Fix unused loop control variable for pre-commit
stancld Apr 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/torchmetrics/metric.py
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ def reset(self) -> None:
if isinstance(default, Tensor):
setattr(self, attr, default.detach().clone().to(current_val.device))
else:
setattr(self, attr, [])
getattr(self, attr).clear() # delete/free list items

# reset internal states
self._cache = None
Expand Down
Loading