Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: ignore::FutureWarning... #2448

Merged
merged 14 commits into from
Mar 15, 2024
Merged

tests: ignore::FutureWarning... #2448

merged 14 commits into from
Mar 15, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 14, 2024

What does this PR do?

This will reduce the testing long (5k warning) by 20k lines with ignoring third-party Future warnings, mainly. coming from reference metrics computations

also not running unitest with verbose since in parallel, it does not easily show if any previous tests failed compared to test running in sequence the last result color is aggregation of all previous

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2448.org.readthedocs.build/en/2448/

@Borda Borda changed the title tests: ignore::FutureWarning:other_package tests: ignore::FutureWarning:other_package Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #2448 (b74fa81) into master (4ed43e6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2448   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         307     307           
  Lines       17363   17363           
======================================
  Hits        11961   11961           
  Misses       5402    5402           

@Borda Borda added enhancement New feature or request test / CI testing or CI labels Mar 14, 2024
@Borda Borda changed the title tests: ignore::FutureWarning:other_package tests: ignore::FutureWarning... Mar 14, 2024
@Borda Borda changed the title tests: ignore::FutureWarning... tests: ignore::FutureWarning... [wip] Mar 14, 2024
@Borda Borda requested a review from ethanwharris as a code owner March 14, 2024 16:43
@Borda Borda changed the title tests: ignore::FutureWarning... [wip] tests: ignore::FutureWarning... Mar 14, 2024
@Borda Borda requested a review from a team March 15, 2024 13:55
@Borda Borda merged commit 819a812 into master Mar 15, 2024
51 of 56 checks passed
@Borda Borda deleted the tests/ignore-warn branch March 15, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant