-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: ignore::FutureWarning...
#2448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
SkafteNicki,
justusschock and
stancld
as code owners
March 14, 2024 00:04
Borda
changed the title
tests: ignore::FutureWarning:other_package
tests: Mar 14, 2024
ignore::FutureWarning:other_package
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2448 +/- ##
======================================
Coverage 69% 69%
======================================
Files 307 307
Lines 17363 17363
======================================
Hits 11961 11961
Misses 5402 5402 |
Borda
changed the title
tests:
tests: Mar 14, 2024
ignore::FutureWarning:other_package
ignore::FutureWarning...
Borda
changed the title
tests:
tests: Mar 14, 2024
ignore::FutureWarning...
ignore::FutureWarning...
[wip]
Borda
changed the title
tests:
tests: Mar 14, 2024
ignore::FutureWarning...
[wip]ignore::FutureWarning...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This will reduce the testing long (5k warning) by 20k lines with ignoring third-party Future warnings, mainly. coming from reference metrics computations
also not running unitest with verbose since in parallel, it does not easily show if any previous tests failed compared to test running in sequence the last result color is aggregation of all previous
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2448.org.readthedocs.build/en/2448/