Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix PR's file changed limit #2412

Merged
merged 2 commits into from
Feb 27, 2024
Merged

ci: fix PR's file changed limit #2412

merged 2 commits into from
Feb 27, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 27, 2024

What does this PR do?

seems that using simple request limited nb files to 30, so if PR was larger other files were ignored, see test against #2335
master response:

unittests/bases unittests/audio unittests/classification

This fix response:

unittests/bases unittests/image unittests/clustering unittests/nominal unittests/detection unittests/regression unittests/text unittests/audio unittests/classification unittests/multimodal
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2412.org.readthedocs.build/en/2412/

@Borda Borda added Priority Critical task/issue test / CI testing or CI labels Feb 27, 2024
@Borda Borda merged commit a3ed72f into master Feb 27, 2024
62 of 66 checks passed
@Borda Borda deleted the ci/fix-diff branch February 27, 2024 19:01
@Borda Borda added the bug / fix Something isn't working label Feb 27, 2024
@mergify mergify bot added the ready label Feb 27, 2024
Borda added a commit that referenced this pull request Mar 16, 2024
Borda added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working Priority Critical task/issue ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants