Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: pyproject & fixing #2403

Merged
merged 4 commits into from
Feb 23, 2024
Merged

lint: pyproject & fixing #2403

merged 4 commits into from
Feb 23, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 22, 2024

What does this PR do?

ensure the correctness

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2403.org.readthedocs.build/en/2403/

@Borda Borda added the enhancement New feature or request label Feb 22, 2024
@Borda Borda enabled auto-merge (squash) February 22, 2024 15:12
@Borda Borda changed the title lint: pyproject lint: pyproject & fixing Feb 22, 2024
@Borda Borda added the bug / fix Something isn't working label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Merging #2403 (e20dac5) into master (91dd704) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2403   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         307     307           
  Lines       17352   17352           
======================================
  Hits        11961   11961           
  Misses       5391    5391           

@Borda Borda requested a review from a team February 22, 2024 17:09
@mergify mergify bot added the ready label Feb 23, 2024
@Borda Borda disabled auto-merge February 23, 2024 09:42
@Borda Borda merged commit 3de406f into master Feb 23, 2024
58 checks passed
@Borda Borda deleted the lint/pyproject branch February 23, 2024 09:42
Borda added a commit that referenced this pull request Mar 16, 2024
* lint: pyproject
* cleaning

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 3de406f)
Borda added a commit that referenced this pull request Mar 18, 2024
* lint: pyproject
* cleaning

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 3de406f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants