Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize aggregation metrics with default floating type #2366

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 9, 2024

What does this PR do?

Fixes #2365

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2366.org.readthedocs.build/en/2366/

@Borda Borda enabled auto-merge (squash) February 9, 2024 12:32
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Merging #2366 (59bb3c9) into master (4527aaf) will not change coverage.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2366   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         305     305           
  Lines       17164   17164           
======================================
  Hits        11836   11836           
  Misses       5328    5328           

@mergify mergify bot added the ready label Feb 9, 2024
@Borda Borda disabled auto-merge February 12, 2024 09:50
@Borda Borda merged commit b6f6e07 into master Feb 12, 2024
58 checks passed
@Borda Borda deleted the bugfix/aggregation_with_default_type branch February 12, 2024 09:51
Borda pushed a commit that referenced this pull request Feb 12, 2024
Borda pushed a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
2 participants