Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: flaky terminated with signal SIGABRT #20537

Merged
merged 2 commits into from
Jan 9, 2025
Merged

test: flaky terminated with signal SIGABRT #20537

merged 2 commits into from
Jan 9, 2025

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 8, 2025

What does this PR do?

addressing #20509 (comment)

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20537.org.readthedocs.build/en/20537/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-14, lightning, 3.9, 2.1, oldest) success
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success
fabric-cpu (macOS-14, lightning, 3.11, 2.2.2) success
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success
fabric-cpu (macOS-14, lightning, 3.12.7, 2.4.1) success
fabric-cpu (macOS-14, lightning, 3.12.7, 2.5.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success
fabric-cpu (ubuntu-22.04, lightning, 3.12.7, 2.4.1) success
fabric-cpu (ubuntu-22.04, lightning, 3.12.7, 2.5.1) success
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success
fabric-cpu (windows-2022, lightning, 3.11, 2.2.2) success
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success
fabric-cpu (windows-2022, lightning, 3.12.7, 2.4.1) success
fabric-cpu (windows-2022, lightning, 3.12.7, 2.5.1) success
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success
fabric-cpu (macOS-14, fabric, 3.12.7, 2.5.1) success
fabric-cpu (ubuntu-22.04, fabric, 3.12.7, 2.5.1) success
fabric-cpu (windows-2022, fabric, 3.12.7, 2.5.1) success

These checks are required after the changes to tests/tests_fabric/utilities/test_distributed.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to tests/tests_fabric/utilities/test_distributed.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49%. Comparing base (8c2d263) to head (9df656d).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8c2d263) and HEAD (9df656d). Click for more details.

HEAD has 568 uploads less than BASE
Flag BASE (8c2d263) HEAD (9df656d)
cpu 147 24
lightning 110 19
pytest 73 26
python3.9 36 6
python3.11 36 6
lightning_fabric 19 7
python3.10 18 3
python3.12.7 57 9
pytorch2.1 27 0
pytest-full 76 0
pytorch2.3 9 0
pytorch_lightning 20 0
pytorch2.2.2 9 0
pytorch2.4.1 10 0
pytorch2.5.1 21 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20537     +/-   ##
=========================================
- Coverage      88%      49%    -39%     
=========================================
  Files         267      264      -3     
  Lines       23380    23324     -56     
=========================================
- Hits        20481    11382   -9099     
- Misses       2899    11942   +9043     

@lantiga lantiga merged commit a944e77 into master Jan 9, 2025
38 checks passed
@lantiga lantiga deleted the test/flake branch January 9, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants