-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update (ci): github action's artifact upgrade v4 #20500
Update (ci): github action's artifact upgrade v4 #20500
Conversation
751664d
to
b485017
Compare
4b47796
to
7ab9753
Compare
…edirects intel.com documentation
7ab9753
to
2afe620
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The direction is good, it just needs some more work with adding patterns and making unique uploads...
pls, have look what I gave done earlier this week for shared utils project: Lightning-AI/utilities#344
for more information, see https://pre-commit.ci
…I/pytorch-lightning into fix_allee_github_artifacts_upload_and_download_eol_v4
This reverts commit ed44fec.
Thanks. I reviewed the changes. |
What does this PR do?
Why
We received the email below stating that we need to upgrade by January.
Here is the recommended upgrade guide that I followed.
Does this introduce breaking change?
According to Github after Jan 9th if we have not upgraded there will be issues running pipelines.
Test Plan
-- dist-packages-870cec2e4fc4ca4f9ea49a94862b7412bd914431.zip
-- dist-packages-e9100e548a5f90fb4e90a189b6f6c80dae4a37e7.zip
Before submitting
- Was this **discussed/agreed** via a GitHub issue? (not for typos and docs) - [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/lightning/blob/master/.github/CONTRIBUTING.md), **Pull Request** section? - [ ] Did you make sure your **PR does only one thing**, instead of bundling different changes together? - Did you make sure to **update the documentation** with your changes? (if necessary) - Did you write any **new necessary tests**? (not for typos and docs) - [ ] Did you verify new and **existing tests pass** locally with your changes? - Did you list all the **breaking changes** introduced by this pull request? - Did you **update the CHANGELOG**? (not for typos, docs, test updates, or minor internal changes/refactors)PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20500.org.readthedocs.build/en/20500/
cc @Borda