-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ignore for hyper params #20213
Open
aseemk98
wants to merge
6
commits into
Lightning-AI:master
Choose a base branch
from
aseemk98:feat/19761_apply_ignore_save_params
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
added ignore for hyper params #20213
aseemk98
wants to merge
6
commits into
Lightning-AI:master
from
aseemk98:feat/19761_apply_ignore_save_params
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseemk98
requested review from
lantiga,
Borda,
tchaton,
awaelchli and
justusschock
as code owners
August 19, 2024 03:09
Looks reasonable, we'll merge with a test : ) Thanks! |
lantiga
added
the
waiting on author
Waiting on user action, correction, or update
label
Nov 12, 2024
Hey @aseemk98 would you have time to add a test? |
Hi! Just wanted to check if this issue is still open. Would love to contribute. |
Sure I'll add a test |
But the build fails with this PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pl
Generic label for PyTorch Lightning package
waiting on author
Waiting on user action, correction, or update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR to enable ignore of args passed to the function instead of ignore only of init_params
Fixes #19761
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20213.org.readthedocs.build/en/20213/