bump: transmission to use neptune only, drop neptune-client
#19265
Conversation
Borda
requested review from
williamFalcon,
awaelchli,
carmocca,
justusschock,
lantiga and
tchaton
as code owners
github-actions
bot
added
pl
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19265 +/- ##
==========================================
- Coverage 84% 48% -35%
==========================================
Files 450 442 -8
Lines 38105 37936 -169
==========================================
- Hits 31871 18378 -13493
- Misses 6234 19558 +13324 |
Borda
changed the title
neptune>=1.0.0neptune only, drop neptune-client
|
@Borda take a look a the response here from @SiddhantSadangi from the neptune team: #18558 (comment) |
Yes, the response was half a year ago, but still, if they support it, the API switch is for legacy |
|
so with installing >>> import neptune
>>> from lightning_utilities.core.imports import RequirementCache
>>> RequirementCache("neptune>=1.0")
Requirement 'neptune>=1.0' metthen install the same >>> import neptune
>>> from lightning_utilities.core.imports import RequirementCache
>>> RequirementCache("neptune>=1.0")
DistributionNotFound: The 'neptune>=1.0' distribution was not found and is required by the application. HINT: Try running `pip install -U 'neptune>=1.0'`
>>> from lightning_utilities.core.imports import module_available
>>> module_available("neptune")
True |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 5685611 | Triggered | Generic High Entropy Secret | 18eeab9 | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 18eeab9 | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 18eeab9 | tests/tests_data/streaming/test_resolver.py | View secret |
| 5685611 | Triggered | Generic High Entropy Secret | 18eeab9 | tests/tests_data/streaming/test_resolver.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Co-authored-by: Carlos Mocholí <[email protected]>
for more information, see https://pre-commit.ci
|
Thanks @Borda for handling this 😉. LGTM 🚀 . We should probably mention this PR here as well: #18555 as it's not going to be fixed according to these PR. We're going to send some communication to our clients about the discontinuation of this support. I'll rebase all my PRs soon after merge of this one 😉. |
sounds good; there is a long runway as this will be part of 2.3 so in a few months 🏃 |
What does this PR do?
With the next feari=ure release let's cut and exclusively support
neptuneand drop legacyneptune-client, see: #19131 (comment)Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19265.org.readthedocs.build/en/19265/
cc @Borda