Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] properly replace proxies in trace_with_replaced_proxy_metadata #1628

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ali-alshaar7
Copy link
Contributor

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@t-vi
Copy link
Collaborator

t-vi commented Jan 10, 2025

Great find, would we want to add a test of sorts?

@t-vi
Copy link
Collaborator

t-vi commented Jan 10, 2025

(The other thing could be to move it to the Processor)

@riccardofelluga
Copy link
Collaborator

What type is proxy_replacement_metadata?

@ali-alshaar7
Copy link
Contributor Author

What type is proxy_replacement_metadata?

{str: Proxy} @riccardofelluga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants