Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up imports of jit_ext.py #1588

Merged
merged 2 commits into from
Jan 21, 2025
Merged

clean up imports of jit_ext.py #1588

merged 2 commits into from
Jan 21, 2025
+37 −83

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Dec 27, 2024

What does this PR do?

some cleaning of jit_ext's imports

@crcrpar crcrpar force-pushed the crpa/jit-ext-imports branch 2 times, most recently from d3254d5 to d4b35e7 Compare January 2, 2025 16:21
t-vi
t-vi reviewed Jan 6, 2025
View reviewed changes
thunder/core/jit_ext.py Outdated Show resolved Hide resolved
crcrpar and others added 2 commits January 21, 2025 09:42
@crcrpar @t-vi
imports
cf53463 
Signed-off-by: Masaki Kozuki <[email protected]>
@t-vi
finish cleanup
24b6bae
@t-vi t-vi force-pushed the crpa/jit-ext-imports branch from d4b35e7 to 24b6bae Compare January 21, 2025 08:59
@t-vi t-vi enabled auto-merge (squash) January 21, 2025 08:59
t-vi
t-vi approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crcrpar . I took the liberty of making it more about the top level import while rebasing.

@t-vi t-vi merged commit 12d0534 into main Jan 21, 2025
49 checks passed
@t-vi t-vi deleted the crpa/jit-ext-imports branch January 21, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crcrpar @t-vi