-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AdHocExecutor -> TransientOperatorExecutor and add documentation #1573
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
I don't think "Operator" adds anything for clarity here. |
Sure, let's rename it to Temporary. The base class is Executor and its child OperatorExecutor keeps the "Executor" suffix. By this logic, any child of OperatorExecutor can maintain OperatorExecutor for consistency. TemporaryOperatorExecutor is not a FusionExecutor, but a TemporaryExecutor could also be a FusionExecutor. |
The executor does something beyond operators, though. |
This may be worth a brief online chat, too, because I'm curious about the details of this executor. It sounds interesting! |
We need a more precise name for an unnamed operator executor than "AdHoc," which can be ambiguous and difficult for new developers to understand. This class is used for dynamic/runtime registrations and manages one-off operations, and this should be reflected in the name to be self-documenting. I chose "Transient" because it communicates the executor's temporary/ephemeral nature.
Some other potential names based on functionality:
cc @Borda @apaz-cli