Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AdHocExecutor -> TransientOperatorExecutor and add documentation #1573

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

IvanYashchuk
Copy link
Collaborator

@IvanYashchuk IvanYashchuk commented Dec 19, 2024

We need a more precise name for an unnamed operator executor than "AdHoc," which can be ambiguous and difficult for new developers to understand. This class is used for dynamic/runtime registrations and manages one-off operations, and this should be reflected in the name to be self-documenting. I chose "Transient" because it communicates the executor's temporary/ephemeral nature.

Some other potential names based on functionality:

  • DynamicOperatorExecutor - highlights dynamic nature
  • TemporaryOperatorExecutor - emphasizes temporary aspect
  • RuntimeOperatorExecutor - focuses on runtime registration

cc @Borda @apaz-cli

@IvanYashchuk IvanYashchuk added the documentation Improvements or additions to documentation label Dec 19, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Dec 19, 2024
@t-vi
Copy link
Collaborator

t-vi commented Dec 19, 2024

I don't think "Operator" adds anything for clarity here.
Temporary sounds better than Transient to me.

@IvanYashchuk
Copy link
Collaborator Author

Sure, let's rename it to Temporary.

The base class is Executor and its child OperatorExecutor keeps the "Executor" suffix. By this logic, any child of OperatorExecutor can maintain OperatorExecutor for consistency. TemporaryOperatorExecutor is not a FusionExecutor, but a TemporaryExecutor could also be a FusionExecutor.

@IvanYashchuk IvanYashchuk added the documentation Improvements or additions to documentation label Dec 19, 2024
@t-vi
Copy link
Collaborator

t-vi commented Dec 19, 2024

The executor does something beyond operators, though.

@mruberry
Copy link
Collaborator

This may be worth a brief online chat, too, because I'm curious about the details of this executor. It sounds interesting!

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants