mark tests

Lightning-AI · Nov 4, 2024 · aa330f3 · aa330f3
1 parent 8cd21e5
commit aa330f3
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/.azure/hpu-tests.yml b/.azure/hpu-tests.yml
@@ -147,8 +147,8 @@ jobs:
           -k test_autocast_operators_override --runxfail \
           -W ignore::FutureWarning --junitxml=hpu_precision_test_override-results.xml
       env:
-        LOWER_LIST : tests/test_pytorch/ops_fp32.txt
-        FP32_LIST : tests/test_pytorch/ops_bf16.txt
+        LOWER_LIST: tests/test_pytorch/ops_fp32.txt
+        FP32_LIST: tests/test_pytorch/ops_bf16.txt
       displayName: 'HPU precision test'
 
     - bash: |

diff --git a/src/lightning_habana/utils/imports.py b/src/lightning_habana/utils/imports.py
@@ -21,7 +21,7 @@
 from lightning_habana.utils.resources import _HABANA_FRAMEWORK_AVAILABLE, get_hpu_synapse_version  # noqa: F401
 
 _HPU_SYNAPSE_GREATER_EQUAL_1_17_0 = Version(get_hpu_synapse_version()) >= Version("1.17.0")
-_HPU_SYNAPSE_GREATER_EQUAL_1_18_0 = Version(get_hpu_synapse_version()) >= Version("1.18.0")
+_HPU_SYNAPSE_GREATER_1_18_0 = Version(get_hpu_synapse_version()) > Version("1.18.0")
 _TORCH_LESSER_EQUAL_1_13_1 = compare_version("torch", operator.le, "1.13.1")
 _TORCH_GREATER_EQUAL_2_0_0 = compare_version("torch", operator.ge, "2.0.0")
 _TORCH_LESSER_2_3_0 = Version(Version(torch.__version__).base_version) < Version("2.3.0")

diff --git a/tests/test_pytorch/test_compile.py b/tests/test_pytorch/test_compile.py
@@ -35,6 +35,7 @@
 from lightning_habana.pytorch.accelerator import HPUAccelerator
 from lightning_habana.pytorch.plugins import HPUPrecisionPlugin
 from lightning_habana.pytorch.strategies import HPUDDPStrategy, SingleHPUStrategy
+from lightning_habana.utils.imports import _HPU_SYNAPSE_GREATER_1_18_0
 from lightning_habana.utils.resources import get_device_name_from_hlsmi
 
 
@@ -221,6 +222,7 @@ def test_ddp_strategy_with_compile(tmp_path, arg_hpus):
     assert _strategy._ddp_kwargs["find_unused_parameters"] is True
 
 
+@pytest.mark.skipif(_HPU_SYNAPSE_GREATER_1_18_0, reason="Test valid for Synapse version <= 1.18.0")
 @pytest.mark.usefixtures("_is_compile_allowed")
 @pytest.mark.parametrize(
     ("record_module_names", "expectation"),

diff --git a/tests/test_pytorch/test_precision.py b/tests/test_pytorch/test_precision.py
@@ -39,7 +39,7 @@
 from lightning_habana.pytorch.plugins import HPUPrecisionPlugin
 from lightning_habana.pytorch.plugins.precision import _PRECISION_INPUT
 from lightning_habana.pytorch.strategies import HPUDDPStrategy, SingleHPUStrategy
-from lightning_habana.utils.imports import _HPU_SYNAPSE_GREATER_EQUAL_1_18_0
+from lightning_habana.utils.imports import _HPU_SYNAPSE_GREATER_1_18_0
 from lightning_habana.utils.resources import get_device_name_from_hlsmi
 
 supported_precision = get_args(_PRECISION_INPUT)
@@ -165,7 +165,7 @@ def forward(self, x):
 
 
 @pytest.mark.xfail(strict=False, reason="Env needs to be set")
-@pytest.mark.skipif(_HPU_SYNAPSE_GREATER_EQUAL_1_18_0, reason="Will be fixed in a future synapse version.")
+@pytest.mark.skipif(_HPU_SYNAPSE_GREATER_1_18_0, reason="Test valid for Synapse version <= 1.18.0")
 def test_autocast_operators_override(tmpdir):
     """Tests operator dtype overriding with torch autocast."""
     # The override lists are set in cmdline

diff --git a/tests/test_pytorch/test_profiler.py b/tests/test_pytorch/test_profiler.py
@@ -47,6 +47,10 @@
 if _KINETO_AVAILABLE:
     from lightning_habana.pytorch.profiler.profiler import HPUProfiler
 
+from lightning_habana.utils.imports import _HPU_SYNAPSE_GREATER_1_18_0
+
+pytestmark = pytest.mark.skipif(_HPU_SYNAPSE_GREATER_1_18_0, reason="Tests valid for Synapse version <= 1.18.0")
+
 
 @pytest.fixture()
 def _check_distributed(device_count):