Tweaks and Upgrades #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the application
|
Great work! Does it support Nova 4? |
|
@interpegasus nope. These changes were made before Nova 4, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Hey, there. I had the need to implement in Nova for an app, tried installing your package but found some roadblocks (my project uses PHP >8.0), so I made the necessary changes to make it work and figured I could contribute here.
While I was testing it, I noticed that the recovery flow wasn't working, so I fixed that. And then I noticed I had to reconfigure the authenticator app after using a recovery code (it generated a new secret and new codes), but that doesn't seem necessary. Fortify just replaces the used code with a new one, so that should do the trick, right?
These are all breaking changes, so you may need a major version bump. Since I'm working on a new project, I didn't need to migrate existing users, and I don't think it's possible (because of the hashing to encryption change), so if you're interested in a migration path for users of the package, we can bring back the hashing stuff implement a configuration that allows users to choose between encryption/hashing for the recovery codes.
I changed from hashing to encryption to allow users to view their recovery codes again once they are inside the app (since recovery codes change - when you use one, that one gets cycled and a new one takes its place).