fix(BaseLink): Return href='#' when onClick passed to BaseLink (befor…

…e there wasn't an href at all c
LeonardoGentile · Jun 16, 2017 · 63ed19f · 63ed19f
1 parent 5c7ca75
commit 63ed19f
Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -545,9 +545,9 @@ function logMeIn(e) {
 function Menu(props) {
   return (
     <nav>
-      <Link routerStore={props.routerStore} routeName='home' routeOptions={{reload: true}}>Home</Link>
-      <Link router={props.router} routeName='home'>About</Link>
-      <Link onClick={logMeIn} >Login</Link>
+      <BaseLink routerStore={props.routerStore} routeName='home' routeOptions={{reload: true}}>Home</Link>
+      <BaseLink router={props.router} routeName='home'>About</Link>
+      <BaseLink onClick={logMeIn} >Login</Link>
     </nav>
   );
 }

diff --git a/src/modules/BaseLink.js b/src/modules/BaseLink.js
@@ -60,7 +60,7 @@ class BaseLink extends Component {
       }
       return this.router.buildPath(routeName, routeParams);
     }
-    return null;
+    return '#';
   }
 
   clickHandler(evt) {