Update env.py #70
Open
Update env.py #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poker prevent decreasing bet with [bet x]
| if amount >= self.state.game_state["current_bet"]: | ||
| return "bet", amount | ||
| else: | ||
| return "invalid_bet", None |
There was a problem hiding this comment.
I think this should also set invalid move with a reason ?
There was a problem hiding this comment.
nvm just saw below haha
There was a problem hiding this comment.
hmm I still think it isn't right to do this in the parsing function
DylanASHillier
approved these changes
Mar 4, 2025
| @@ -245,13 +248,20 @@ def _process_betting_action(self, player_id: int, action: str): | |||
| action_type, bet_amount = self._parse_action(action) | |||
There was a problem hiding this comment.
Yeah I think you should do the check here, next to the other validity code... but otherwise this of course makes sense as a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poker prevent decreasing bet with [bet x]