Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves ksni issues in Ubuntu & adding additional menu for battery #5

Merged
merged 1 commit into from
May 29, 2024

Conversation

nate131
Copy link
Contributor

@nate131 nate131 commented May 7, 2024

In Ubuntu the tooltip does not show.

  • Replaced the icons to default "audio-headset"
  • added a new StandardMenu to show battery % and charging status
  • added ID for the ksni Tray

@LennardKittner LennardKittner self-requested a review May 7, 2024 16:09
Copy link
Owner

@LennardKittner LennardKittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your PR. 
I have three things you could consider adding before I merge. However, I'm not sure if these things are even possible.

  1.  Disable the menu item so it cannot be selected with the mouse.
  2.  Add additional menu items for the other indicators, e.g., muted.
  3. On KDE Plasma, the "audio-headset" icon is just a note and not a headset. Do you think it is possible to detect if the "headset" icon exists and, if not, fall back to "audio-headset"?

Again, these are only suggestions, and you don't have to implement them if you don't want to.

@LennardKittner LennardKittner merged commit 8a1ec7b into LennardKittner:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants